feat(react): expose virtual for simpler preamble setup on ssr #890
Conversation
|
superseded by #891 |
hi-ogawa
deleted the
10-01-feat_expose_virtual_for_simpler_preamble_setup_on_ssr
branch
hi-ogawa
restored the
10-01-feat_expose_virtual_for_simpler_preamble_setup_on_ssr
branch
|
Okay, I think I want this one instead of #891 as patching react isn't great. |
Let's push this to upstream vitejs/vite-plugin-react#890
hi-ogawa
changed the title
- Fix typos: "intiialize" → "initialize", "intiialization" → "initialization" - Fix grammar: "a following" → "the following" - Improve wording for clarity and conciseness 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add preamble section to plugin-react-swc README - Update CHANGELOG entries for both plugin-react and plugin-react-swc - Document the new virtual module feature for SSR HMR setup 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hi-ogawa
requested review from
sapphi-red and
ArnaudBarre
and removed request for
sapphi-red
|
If we add support for |
| "./refresh-runtime": "./refresh-runtime.js" | ||
| }, | ||
| "dependencies": { | ||
| "@rolldown/pluginutils": "1.0.0-beta.41" |
There was a problem hiding this comment.
This should be added to SWC deps too (and maybe rsc) because the common package in bundled into react plugins. I'm not a power user of pnpm, but is catalog the best way to unsure it's the same version everywhere?
Also should we use a strict version?
There was a problem hiding this comment.
Ah, this might look weird but I just noticed @rolldown/pluginutils is already in dependencies of all three react packages (and rsc doesn't use it) and they are all pinned with same version. So this should be fine.
There was a problem hiding this comment.
Yes ok with dependabot this should be done in sync 👍
That sounds better, but I'm actually not sure how that works. Would that be something like this? {
transform: {
order: 'post',
handler(code, id) {
const info = this.getModuleInfo(id);
if (info?.isEntry) {
return `import "..";` + code;
}
}
}
} |
I was thinking about a code like below as {
transform: {
order: 'post',
handler(code, id, { isEntry }) {
if (isEntry) {
return `import "..";` + code;
}
}
}
}But turns out |
Description
This PR adds virtual module
@vitejs/plugin-react/preamble, which allows SSR app to easily enable HMR by adding import side effect at the top of client entry without handlingtransformIndexHtml. Seeplayground/ssr-react/src/entry-client.jsxfor example.